This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/5] m68k: Fix sigaction kernel definition (BZ #23960)
On Dez 12 2018, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
> The m68k kernel does define SA_RESTORER on arch/m68k/include/asm/signal.h
> (__ARCH_HAS_SA_RESTORER),
These are not the same. The latter only tells <linux/signal_types.h> to
add the sa_restorer member, independent of SA_RESTORER (which m68k
doesn't define).
> but the only difference it makes for m68k is at flush_signal_handlers
> where kernel sets the sa_restorer to NULL. So it indeed should be safe
> to just use default kernel_sigaction.h (I don't see any signal test
> issues). Updated patch below.
This fails to add the sa_restorer member, causing the signal mask to be
mishandled.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."