This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Y2038: add function __localtime64
On Wed, 12 Dec 2018, Albert ARIBAUD (3ADEV) wrote:
> extern struct tm *__localtime_r (const time_t *__timer,
> struct tm *__tp) attribute_hidden;
> -
I don't think this blank line removal should be included in this patch.
> +In order to make @theglibc{} Y2038-proof, 64-bit time support must be
> +added to those 32-bit-time-only architectures. When adding new code
Two spaces after '.' in Texinfo source, throughout.
> +@item
> +Y2038 support code added to @theglibc{} must not modify or remove
> +existing symbols on 32-bit time architectures. This ensures that
> +existing user object code will remain able to link against the newer
> +Y2038-proof @glibcadj{}.
@glibcadj{} is incorrect here, this is not an adjective use.
> +aleady Y2038-proof.
"already"
> +is supporte (@code{time_t} is 64-bit, @code{time()} returns a 64-bit time
"supported"
Do not use () after a function name to indicate it's a function (see the
GNU Coding Standards).
> +/* Provide a 32-bit variant if needed */
Comments, both in code and in the manual, should follow GNU standards, so
end with ". " (full stop, two spaces).
> /* The C Standard says that localtime and gmtime return the same pointer. */
> struct tm _tmbuf;
>
> -
> /* Return the `struct tm' representation of *T in local time,
> using *TP to store the result. */
> struct tm *
> @@ -31,11 +30,24 @@ __localtime_r (const time_t *t, struct tm *tp)
> }
> weak_alias (__localtime_r, localtime_r)
>
> -
> /* Return the `struct tm' representation of *T in local time. */
Again, I think the patch should avoid stray removals of blank lines.
--
Joseph S. Myers
joseph@codesourcery.com