This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] Add tests for the long double version of ecvt and fcvt
- From: Florian Weimer <fweimer at redhat dot com>
- To: "Gabriel F. T. Gomes" <gabriel at inconstante dot eti dot br>
- Cc: <libc-alpha at sourceware dot org>
- Date: Thu, 13 Dec 2018 16:40:08 +0100
- Subject: Re: [PATCH v3] Add tests for the long double version of ecvt and fcvt
- References: <20181108222916.27414-1-gabriel@inconstante.eti.br> <87bm5sulmt.fsf@oldenburg2.str.redhat.com> <20181212110741.40805913@tereshkova> <87imzyri8q.fsf@oldenburg2.str.redhat.com> <20181212144903.6526bd46@tereshkova>
* Gabriel F. T. Gomes:
> * misc/Makefile (tests): Remove tst-efgcvt. Add tst-dbl-efgcvt
> and tst-ldbl-efgcvt.
> * misc/tst-efgcvt.c: Renamed to misc/tst-efgcvt-template.c.
> * misc/tst-efgcvt-template.c: Renamed from misc/tst-efgcvt.c.
> (struct testcase, efcvt_func, efcvt_r_func, ecvt_tests)
> (fcvt_tests, output_error, output_r_error, do_test): Use the
> macros defined in tst-dbl-efgcvt.c and tst-ldbl-efgcvt.c to:
> select the type of floating-point variables and arguments; to
> produce extra tests for double and conversion specifiers for
> printf; and to set the names of called functions.
> * misc/tst-dbl-efgcvt.c: New file that defines the macros used
> in tst-efgcvt-template.c.
> * misc/tst-ldbl-efgcvt.c: Likewise.
This version looks okay to me. I'm not a math reviewer, but please feel
free to commit this.
Thanks,
Florian