This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v5 1/1] Add statx conditionals for wordsize-32 *xstat.c


On Mon, 10 Dec 2018, Mao Han wrote:

> diff --git a/sysdeps/unix/sysv/linux/generic/wordsize-32/xstat64.c b/sysdeps/unix/sysv/linux/generic/wordsize-32/xstat64.c

> +    {
> +#ifdef __NR_fstatat64
>      return INLINE_SYSCALL (fstatat64, 4, AT_FDCWD, name, buf, 0);
> -

As this statement is moving inside braces, it also needs to be reindented 
two more columns to the right.

> +extern void __cp_stat_statx (struct stat *to, struct statx *from)
> +  attribute_hidden;

There's no such function any more, so this declaration should be removed.

This patch is OK with those changes.  Please complete the form 
https://sourceware.org/cgi-bin/pdw/ps_form.cgi for write access, listing 
me as sponsor.  Please also create an account on the glibc wiki if you 
don't already have one, and post the username so that you can be given 
write access to that.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]