This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v4] Y2038: add function __localtime64

* Albert ARIBAUD:

> Hi Joseph,
>
> On Tue, 18 Dec 2018 01:09:25 +0000, Joseph Myers
> <joseph@codesourcery.com> wrote :
>
>> On Tue, 18 Dec 2018, Rafal Luzynski wrote:
>> 
>> > Perhaps you should use:
>> > 
>> >     the @glibcadj{}
>> > 
>> > instead?  
>> 
>> I don't think the word "the" belongs there at all; just @glibcadj{}.
>
> I'd run 'make manual' instead of 'make pdf'. :(
>
> This was pushed already, and master has't moved yet. For the sake of
> bisectability, should I do a git amend (for this and changelog typo
> altogether)?
>
> Commit is ready anyway and checked against both make check and
> make pdf.

Please push a new commit and do not amend the existing commit.

Thanks,
Florian
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]