This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Script to generate ChangeLog-like output
On 19/12/18 4:33 PM, Szabolcs Nagy wrote:
if a commit has multiple authors currently that's only
tracked in the changelog, so there needs to be a way to
somehow specify multiple authors in git commits to
correctly generate the changelog.
Yeah we had discussed using Signed-off-by but I just forgot to implement
it in this script. I'll add it.
if something is changed under an #if conditional, that
condition may be more than 80 chars, but currently the
script prints it on a single line.
I haven't put in any smarts to wrap the text because that's just going
to be painful to implement. If it's not too bad, I'll take a stab at
that later.
if a function is renamed it says it's removed and a new
function is added with the new name.
Yeah that's a known limitation; there's no way for a script to know that
right now. Maybe in future one could implement smarts that compare the
bodies of all added and removed functions and guess that there was a rename.
it cannot tell if a file is rewritten from scratch and
then it may generate a large changelog instead of just
saying "Rewritten".
True, I would consider it an enhancement over the ChangeLog though, if
knowing exactly what changed is needed. Maybe if that's considered too
verbose, I could later look at the possibility of listing differences
only if the modification percentage is less than a certain threshold.
Although git doesn't always give that information and we may have to
compute that first if it's not available.
Siddhesh