This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] regex: simplify Gnulib port

From: Siddhesh Poyarekar <siddhesh at gotplt dot org>
To: Paul Eggert <eggert at cs dot ucla dot edu>, libc-alpha at sourceware dot org
Date: Thu, 27 Dec 2018 07:10:52 +0530
Subject: Re: [PATCH] regex: simplify Gnulib port
References: <20181226222354.1860-1-eggert@cs.ucla.edu>

On 27/12/18 3:53 AM, Paul Eggert wrote:

This simplifies the code, by removing stuff intended for porting
to Gnulib but no longer needed there.
* posix/regcomp.c [!_LIBC]: No need to put #ifdef _LIBC around
uses of libc_hidden_def, weak_alias.
* posix/regcomp.c, posix/regexec.c: Use __restrict rather than
_Restrict_ except for public-facing headers.
* posix/regex_internal.h (attribute_hidden) [!_LIBC]:
Remove; already defined elsewhere.
* posix/regex.c, posix/regex_internal.h:
Use __GNUC_PREREQ instead of rolling our own.
* posix/regex_internal.h (__GNUC_PREREQ): Remove duplicate defn.


Looks good to me.

Thanks,
Siddhesh

References:
- [PATCH] regex: simplify Gnulib port
  - From: Paul Eggert

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]