Re: [PATCH v2 00/12] Linux termios refactor

[Siddhesh Poyarekar <siddhesh at gotplt dot org>]

On 28/12/18 6:39 AM, Adhemerval Zanella wrote:
> This patchset is an updated version of my previous version [1]. The main
> changes are just the update commit message for third part (termios:
> Consolidate termios c_cc symbolic constants) to add powerpc as affected
> architecture and to mention BZ#23783 on sixth part (termios: Consolidate
> Baud Rate Selection definitions).
>
> I am resending the whole set mainly because Siddhesh has asked to easier
> the review.
>
> [1] https://sourceware.org/ml/libc-alpha/2018-10/msg00255.html
>
> Adhemerval Zanella (12):
>    termios: Define TIOCSER_TEMT with __USE_MISC (BZ#17783)
>    termios: Consolidate struct termios
>    termios: Consolidate termios c_cc symbolic constants
>    termios: Consolidate Input Modes definitions.
>    termios: Consolidate Output Modes definitions
>    termios: Consolidate Baud Rate Selection definitions
>    termios: Consolidate control mode definitions
>    termios: Consolidate local mode definitions
>    termios: Consolidate tcflow symbolic constants
>    termios: Remove Linux _IOT_termios
>    termios: Add powerpc termios-misc
>    termios: Consolidate termios.h

I've reviewed this patchset and it looks good to me overall.  This set 
should not result in any codegen changes so if you haven't already done 
that, please verify that there are no changes.  DWARF will change of 
course and you could work around it by comparing 'objdump -d' outputs of 
the binaries (all DSOs and test binaries) instead of their shasums.

Also, you may need to update the copyright line depending on whether you 
commit before the script to update the year runs or after.

Siddhesh