This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: misc/tst-ttyname time outs
On 1/2/19 1:51 PM, Florian Weimer wrote:
> * Carlos O'Donell:
>
>> I think we can do just a bit better than just UNSUPPORTED.
>>
>> Let me be more specific with my suggestion.
>>
>> The test could print an informative message of the form:
>>
>> "info: posix_openpt: Failed with errno %d. Consider increasing limits."
>
> Yes, that's what I meant.
>
> I don't think we should start printing sysctls and mount options here
> (or systemd-nspawn arguments).
Agreed, we are dealing with tests here, and developers of glibc need to
have enough knowledge to know how to increase the limits.
>> I will note that we are inconsistent in our use of UNSUPPORTED for ENOSPC
>> in that we often hard-fail the ENOSPC failures because we expect to have
>> infinite disk space for testing.
>>
>> Perhaps just EMFILE and ENFILE should be handled as UNSUPPORTED?
>
> This ENOSPC comes from the max= mount option on the devpts instance, I
> think. So it's different.
Ah! OK, so this is truly different then, if that's the case then I'm OK
with it being included.
--
Cheers,
Carlos.