This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] power: Fix VSCR position on ucontext
- From: Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>
- To: Tulio Magno Quites Machado Filho <tuliom at ascii dot art dot br>, Rogerio Alves <rcardoso at linux dot ibm dot com>, "Gabriel F. T. Gomes" <gabriel at inconstante dot eti dot br>
- Cc: nd <nd at arm dot com>, Florian Weimer <fweimer at redhat dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Date: Fri, 11 Jan 2019 12:01:27 +0000
- Subject: Re: [PATCH] power: Fix VSCR position on ucontext
- References: <8a619ad1-b7f2-04f8-f9a7-0a19cbf98f4c@linux.ibm.com> <87lg5va6a6.fsf@oldenburg.str.redhat.com> <20181116111825.43b60283@tereshkova.br.ibm.com> <5e1d1cab-7c91-90f8-82d2-fd38f8676f30@linux.ibm.com> <20181207162959.5e5d8933@tereshkova> <20181210153658.32b0e266@tereshkova> <87tvjl8bx7.fsf@linux.ibm.com> <ecf16bc6-c756-1147-4a72-03efbdd64ef4@linux.ibm.com> <87k1jc5lzs.fsf@linux.ibm.com>
On 10/01/2019 19:52, Tulio Magno Quites Machado Filho wrote:
>> /* This test is supported only on POWER 5 or higher. */
>> +#define PPC_CPU_SUPPORTED (PPC_FEATURE_POWER5 | PPC_FEATURE_POWER5_PLUS | \
>> + PPC_FEATURE_ARCH_2_05 | PPC_FEATURE_ARCH_2_06 | \
>
> The GNU Coding Standard requires to replace 8 spaces with a tab.
> Fixed locally. ;-)
there was a discussion recently, that actually it does not
require such thing (it's just an unfortunate default in
emacs which makes the code unreadable in any way other than
8 space == 1 tab, also breaks patch review and email replies,
but we have to format this way for the sake of emacs users
who otherwise would mess up white space formatting).