This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] elf: Fix LD_AUDIT for modules with invalid version (BZ#24122)
On 23/01/2019 17:00, Adhemerval Zanella wrote:
> On 23/01/2019 16:02, Carlos O'Donell wrote:
>> It is not "invalid" and I think printing that will lead to confusion.
>>
>> Likewise "expected minimum" ignores that 0 is low-enough but should also be ignored.
>>
>> I think this needs a cleanup, and I should have been clearer:
>>
>> For lav == 0 we should print "Auditor requested to be ignored (returned version of 0)."
>>
>> For lav > LAV_CURRENT "Auditor disabled since expected version %d is greater than supported version %d."
>>
>> All the information a developer needs is now in those messages.
>>
>> We should be clear about why it's disabled.
>
> Right, I changed to:
>
> ---
> if (GLRO(dl_debug_mask) & DL_DEBUG_FILES)
> {
> _dl_debug_printf ("\
> \nfile=%s cannot be loaded as audit interface; ignored.\n", name);
> if (laversion == NULL)
> _dl_debug_printf (
> " la_version function not found.\n");
> else
> {
> if (lav == 0)
> _dl_debug_printf (
> " auditor requested to be ignored (returned version of 0).\n");
> else
> _dl_debug_printf (
> " auditor disabled since expected version %d is greater than "
> "supported version %d.\n",
> lav, LAV_CURRENT);
> }
> }
>
Siddhesh,
It is acceptable for 2.29?