This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v9 2/2] strftime: Pass the additional flags from "%EY" to "%Ey" [BZ #24096]
- From: Rafal Luzynski <digitalfreak at lingonborough dot com>
- To: TAMUKI Shoichi <tamuki at linet dot gr dot jp>, libc-alpha at sourceware dot org
- Cc: Zack Weinberg <zackw at panix dot com>
- Date: Wed, 23 Jan 2019 22:42:54 +0100 (CET)
- Subject: Re: [PATCH v9 2/2] strftime: Pass the additional flags from "%EY" to "%Ey" [BZ #24096]
- References: <201901220144.AA04206@tamuki.linet.gr.jp> <201901220153.AA04208@tamuki.linet.gr.jp>
22.01.2019 02:53 TAMUKI Shoichi <tamuki@linet.gr.jp> wrote:
>
> The full representation of the alternative calendar year (%EY)
> typically includes an internal use of "%Ey". As a GNU extension,
> apply any flags on "%EY" (e.g. "%_EY", "%-EY") to the internal "%Ey",
> allowing users of "%EY" to control how the year is padded.
>
> ChangeLog:
>
> [BZ #24096]
> * manual/time.texi (strftime): Document "%EC" and "%EY".
> * time/Makefile (tests): Add tst-strftime2.
> (LOCALES): Add ja_JP.UTF-8, lo_LA.UTF-8, and th_TH.UTF-8.
> * time/strftime_l.c (__strftime_internal): Add argument yr_spec to
> override padding for "%Ey".
> If an optional flag ('_' or '-') is specified to "%EY", interpret the
> "%Ey" in the subformat as if decorated with that flag.
> * time/tst-strftime2.c: New file.
> ---
> NEWS | 4 ++
> manual/time.texi | 11 +++++
> time/Makefile | 5 +-
> time/strftime_l.c | 18 ++++---
> time/tst-strftime2.c | 132
> +++++++++++++++++++++++++++++++++++++++++++++++++++
> 5 files changed, 161 insertions(+), 9 deletions(-)
> create mode 100644 time/tst-strftime2.c
The code in this patch is OK for me.
Reviewed-by: Rafal Luzynski <digitalfreak@lingonborough.com>
Zack, can you please verify for the last time that the patch [1] is correct
and give your final OK and "Reviewed-by"? Thank you.
Regards,
Rafal
[1] https://sourceware.org/ml/libc-alpha/2019-01/msg00553.html