This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Fix dlclose / exit running in parallel resulting in dtor being called twice
- From: Paul Pluzhnikov <ppluzhnikov at google dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>, "Carlos O'Donell" <carlos at redhat dot com>
- Date: Wed, 6 Feb 2019 07:15:25 -0800
- Subject: Re: [patch] Fix dlclose / exit running in parallel resulting in dtor being called twice
- References: <CALoOobMptbtaA-vfcyQuepxZrMzsPKPqTWMZbO=vwK9s0FoGhQ@mail.gmail.com> <8736p11cmz.fsf@oldenburg2.str.redhat.com>
On Wed, Feb 6, 2019 at 1:37 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * Paul Pluzhnikov:
>
> > + /* Clear any errors. */
> > + dlerror ();
> > + return dso;
> > +}
>
> Why did you add the dlerror call in the success case?
I don't remember / can't recall.
But it seems like it should always be a no-op. Do you have a case
where dlopen() succeeds and dlerror() is not a no-op?
Thanks,
--
Paul Pluzhnikov