This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] nptl: Fix join/tryjoin comments.

From: Florian Weimer <fweimer at redhat dot com>
To: Carlos O'Donell <carlos at redhat dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Tue, 12 Feb 2019 10:55:53 +0100
Subject: Re: [PATCH] nptl: Fix join/tryjoin comments.
References: <448cd43d-8f24-7d02-e6dc-b6fa8e0dc44e@redhat.com> <87y36matwx.fsf@oldenburg2.str.redhat.com> <9768e60b-475f-1233-b3b6-d26d582e8ed4@redhat.com>

* Carlos O'Donell:

> Why is the comment wrong? Or do you mean to say the comment could be
> made more accurate?

Let's go back a step.  My understanding is that pthread_join and
pthread_timedjoin_np are both cancellation points, but
pthread_tryjoin_np is not.  Are you saying that pthread_timedjoin_np is
not a cancellation point?

I assume that would be a bug.

Thanks,
Florian

Follow-Ups:
- Re: [PATCH] nptl: Fix join/tryjoin comments.
  - From: Adhemerval Zanella

References:
- [PATCH] nptl: Fix join/tryjoin comments.
  - From: Carlos O'Donell
- Re: [PATCH] nptl: Fix join/tryjoin comments.
  - From: Florian Weimer
- Re: [PATCH] nptl: Fix join/tryjoin comments.
  - From: Carlos O'Donell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]