This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Changes to "Contribution Checklist" -- Format of the contribution.


Executive Summary
=================

I would like to propose that the "Contribution Checklist"
tell first time developers to send a 'git format-patch'
file or inlined text to the list for patch review instead
of a split patch and distinct ChangeLog.

Details
=======

I find it much easier to review patches which are effectively
an inlined 'git format-patch' file, or an attached 
'git format-patch' file which I can apply right away.

I use the the standard ChangeLog merge-driver for git and
I've literally had zero problems with this. So splitting
out the ChangeLog as the "Contribution Checklist" recommends
is something many of us have stopped doing.

It's simply so much easier to pile on a bunch of commits in
your local tree while you work, use git rebase -i to fix
things and edit, and then git format-patch to get a series
of patches ready to go.

Having the ChangeLog split out makes work for me, and
is annoying.

Having a 'git format-patch' file shows clearly what
will be committed as part of the commit message for
which we often want careful review to record the intent
of the change in a logical way.

Can we get consensus to change the "Contribution Checklist"
to suggest a 'git format-patch' patch?

-- 
Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]