This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] powerpc: Fix build of wcscpy with --disable-multi-arch


Since the commit

commit 81a14439417552324ec6ca71f65ddf8e7cdd51c7
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Tue Feb 5 17:35:12 2019 -0200

    wcsmbs: optimize wcscat

powerpc64 and powerpc64le builds fail when configured with
--disable-multi-arch, due to an undefined reference to __GI___wcscpy.
This patch fixes this on sysdeps/powerpc/powerpc64/power6/wcscpy.c,
which is only used when multi-arch is disabled.

This patch does nothing for the failures on 32-bits powerpc builds,
because the file is under the powerpc64 subdirectory, however, powerpc
builds were already failing with --disable-multi-arch, with multiple
error messages, even before the aforementioned commit.

Tested for powerpc, powerpc64, and powerpc64le with multi-arch enabled
(all pass) and disabled (powerpc still fails as explained above).

	* sysdeps/powerpc/powerpc64/power6/wcscpy.c (WCSCPY): Define to
	__wcscpy, then use libc_hidden_def and weak_alias to bind it to
	__GI___wcscpy and wcscpy.
---
 sysdeps/powerpc/powerpc64/power6/wcscpy.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sysdeps/powerpc/powerpc64/power6/wcscpy.c b/sysdeps/powerpc/powerpc64/power6/wcscpy.c
index 722c8f995b..59cfb28832 100644
--- a/sysdeps/powerpc/powerpc64/power6/wcscpy.c
+++ b/sysdeps/powerpc/powerpc64/power6/wcscpy.c
@@ -1 +1,4 @@
+#define WCSCPY __wcscpy
 #include <sysdeps/powerpc/power6/wcscpy.c>
+libc_hidden_def (__wcscpy)
+weak_alias (__wcscpy, wcscpy)
-- 
2.14.5


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]