This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v4] Use a proper C tokenizer to implement the obsolete typedefs test.
On Mon, Mar 11, 2019 at 11:47 PM Carlos O'Donell <carlos@redhat.com> wrote:
> On 3/11/19 8:59 PM, Zack Weinberg wrote:
> >> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> >
> > Is it now the convention that we put Reviewed-by: lines into the final
> > commit message, or just that we say that on the mailing list?
>
> Please ad the reviewed-by lines into the final commit message.
OK, done.
> I would like to see this become the way in which we more accurately
> track reviewer participation and highlight the value of reviewers
> to everyone investing in glibc.
*nod*
> > Do you still want me to change it?
>
> No.
OK. Patch now committed.
zw