Re: [PATCH] Remove obsolete, never-implemented XSI STREAMS declarations

[Florian Weimer <fweimer at redhat dot com>]

* Carlos O'Donell:

> Reviewed-by: Carlos O'Donell <carlos@rehdat.com>

My pre-push testing revealed that my previous testing had been
insufficient, and I had to make the changes below.

(Hurd does not have any other GLIBC_2.30 reference, which is why had to
add the section to posix/Versions.)

Does your Reviewed-by: still stand?

Thanks,
Florian

diff --git a/ChangeLog b/ChangeLog
index cf62a1a1c8..1688c47781 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,4 +1,4 @@
-2019-02-26  Florian Weimer  <fweimer@redhat.com>
+2019-03-14  Florian Weimer  <fweimer@redhat.com>
 
 	Remove obsolete, never-implemented XSI STREAMS declarations.
 	* manual/terminal.texi (Allocation): Remove portability note and
@@ -13,6 +13,9 @@
 	(conformtest-headers-POSIX2008): Likewise.
 	* posix/compat-streams.c: New file.
 	* posix/Makefile (routines): Add it.
+	* posix/Versions (GLIBC_2.1): Add fattach, fdetach, getmsg,
+	getpmsg, isastream, putmsg, putpmsg.
+	(GLIBC_2.30): New section.
 	* bits/stropts.h: Remove file.
 	* bits/xtitypes.h: Likewise.
 	* conform/data/stropts.h-data: Likewise.
diff --git a/posix/Versions b/posix/Versions
index ad693ae9a7..7d06a6d0c0 100644
--- a/posix/Versions
+++ b/posix/Versions
@@ -80,6 +80,10 @@ libc {
     # w*
     waitid; wordexp; wordfree;
   }
+  GLIBC_2.1 {
+    # Compat symbols for the obsolete, unimplemented XSI streams extension.
+    fattach; fdetach; getmsg; getpmsg; isastream; putmsg; putpmsg;
+  }
   GLIBC_2.1.2 {
     # functions used in other libraries
     __vfork;
@@ -141,6 +145,8 @@ libc {
     posix_spawn_file_actions_addchdir_np;
     posix_spawn_file_actions_addfchdir_np;
   }
+  GLIBC_2.30 {
+  }
   GLIBC_PRIVATE {
     __libc_fork; __libc_pread; __libc_pwrite;
     __nanosleep_nocancel; __pause_nocancel;