This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/7] nptl: Add POSIX-proposed sem_clockwait
- From: Mike Crowe <mac at mcrowe dot com>
- To: Yann Droneaud <ydroneaud at opteya dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 14 Mar 2019 14:39:57 +0000
- Subject: Re: [PATCH 2/7] nptl: Add POSIX-proposed sem_clockwait
- References: <cover.b0c66849a87ca79889a49f2f1f2563b1a8a15d8b.1551291557.git-series.mac@mcrowe.com> <47415e51fea8d960fc993cf0e0b8db6a19511d28.1551291557.git-series.mac@mcrowe.com> <bb727705e5c8af91a821207f57ecc3ed8e05c799.camel@opteya.com>
On Thursday 14 March 2019 at 15:09:35 +0100, Yann Droneaud wrote:
> Hi,
>
> Le mercredi 27 février 2019 à 18:23 +0000, Mike Crowe a écrit :
> >
> > diff --git a/sysdeps/pthread/semaphore.h
> > b/sysdeps/pthread/semaphore.h
> > index 41ff927..2e68b16 100644
> > --- a/sysdeps/pthread/semaphore.h
> > +++ b/sysdeps/pthread/semaphore.h
> > @@ -59,6 +59,10 @@ extern int sem_wait (sem_t *__sem);
> > __THROW. */
> > extern int sem_timedwait (sem_t *__restrict __sem,
> > const struct timespec *__restrict __abstime);
> > +
> > +extern int sem_clockwait (sem_t *__restrict __sem,
> > + clockid_t clock,
> > + const struct timespec *__restrict __abstime);
>
> Maybe it can be added with __nonnull ((3)) attribute ?
I was just copying sem_timedwait, but I don't believe there's a reason why
I can't add that.
> > #endif
> >
> > /* Test whether SEM is posted. */
> > diff --git a/sysdeps/unix/sysv/linux/x86_64/64/libpthread.abilist
> > b/sysdeps/unix/sysv/linux/x86_64/64/libpthread.abilist
> > index 931c827..454d340 100644
> > --- a/sysdeps/unix/sysv/linux/x86_64/64/libpthread.abilist
> > +++ b/sysdeps/unix/sysv/linux/x86_64/64/libpthread.abilist
> > @@ -245,6 +245,7 @@ GLIBC_2.3.4 pthread_attr_setaffinity_np F
> > GLIBC_2.3.4 pthread_getaffinity_np F
> > GLIBC_2.3.4 pthread_setaffinity_np F
> > GLIBC_2.3.4 pthread_setschedprio F
> > +GLIBC_2.30 sem_clockwait F
>
> Why is it only added to linux x86_64 ?
Because I wanted to wait to see if the patches were acceptable before
updating all the abilist files.
Mike.