This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Respect CPPFLAGS when generating stdio-lim.h

From: Palmer Dabbelt <palmer at sifive dot com>
To: schwab at suse dot de
Cc: libc-alpha at sourceware dot org
Date: Mon, 18 Mar 2019 04:53:02 -0700 (PDT)
Subject: Re: [PATCH] Respect CPPFLAGS when generating stdio-lim.h

On Mon, 18 Mar 2019 04:47:47 PDT (-0700), schwab@suse.de wrote:

On Mär 18 2019, Palmer Dabbelt <palmer@sifive.com> wrote:

   I'm checking via build-many-glibc.py to make sure this builds, but as
   that never sets CPPFLAGS I don't think it'll find any potential issues.


Since CPPFLAGS is always set by our makefiles I don't understand this
comment.

My point is that bulid-many-glibcs.py isn't adding any additional CPPFLAGS, sowe wouldn't notice anything that might crop up because of how users (whomay have set some odd CPPFLAGS) build their glibc.


Maybe that's being too paranoid, though?

Follow-Ups:
- Re: [PATCH] Respect CPPFLAGS when generating stdio-lim.h
  - From: Andreas Schwab

References:
- Re: [PATCH] Respect CPPFLAGS when generating stdio-lim.h
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]