Re: [PATCH v2 1/2] Y2038: make __mktime_internal compatible with __time64_t

[Lukasz Majewski <lukma at denx dot de>]

Hi Joseph,

> On Sun, 17 Mar 2019, Lukasz Majewski wrote:
> 
> > Do you require following code in include/time.h for timelocal:
> > 
> > #if defined __USE_MISC
> > # if defined(__REDIRECT)
> >   extern int __REDIRECT (timelocal, (struct tm *__tp),
> >                          __mktime64) __THROW);
> > # else
> > #  define timelocal __mktime64
> > # endif
> > #endif  
> 
> include/time.h is an *internal* header, so should not need to test
> __USE_* or use __REDIRECT.
> 
> Something like that would be appropriate in the *installed* header 
> (time/time.h), under whatever __USE_* condition is set by
> _TIME_BITS=64, but only at the later point where we're ready to add
> support for _TIME_BITS=64 to the public headers and corresponding new
> public symbol versions for the new ABIs.
> 
> By using something like that in the installed header you avoid any
> need to define the name __timelocal64 anywhere.
> 

The distinction between internal and external set of headers was
unclear for me.

Thanks for clarification.

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

Attachment: pgpMqZuhwUngx.pgp
Description: OpenPGP digital signature