This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 3/3] time: Add tests for Minguo calendar [BZ #24293]
- From: TAMUKI Shoichi <tamuki at linet dot gr dot jp>
- To: Rafal Luzynski <digitalfreak at lingonborough dot com>, libc-alpha at sourceware dot org
- Cc: Felix Yan <felixonmars at archlinux dot org>
- Date: Wed, 20 Mar 2019 18:21:51 +0900
- Subject: Re: [PATCH 3/3] time: Add tests for Minguo calendar [BZ #24293]
- References: <116203190.41216.1552952155557@poczta.nazwa.pl>
Hello Rafal-san,
From: Rafal Luzynski <digitalfreak@lingonborough.com>
Subject: Re: [PATCH 3/3] time: Add tests for Minguo calendar [BZ #24293]
Date: Tue, 19 Mar 2019 00:35:55 +0100 (CET)
> > Since cmn_TW.UTF8 and zh_TW.UTF-8 are practically the same, I think
> > that the test of only zh_TW.UTF-8 is sufficient.
>
> My intention was to ensure that the patch works not just for zh_TW
> but also for other locales. What is the recommended *_TW which is
> sufficiently different from zh_TW?
Sorry, you are correct. These *_TW locales are similar to each other,
but they are definitely different. Therefore, I have now reconsidered
all *_TW locales (except nan_TW@latin) should be checked.
> I admit the content of all *_TW locales is the same here. If indeed
> all these locales are so similar I don't mind to remove cmn_TW
> and leave zh_TW only.
The *_TW locales are shown below. Please take care of this order in
accordance with ISO 639-[13].
zh_TW Chinese
cmn_TW Mandarin Chinese
hak_TW Hakka Chinese
nan_TW Min Nan Chinese
lzh_TW Literary Chinese
Since the code for these *_TW locales are exactly same, so we can
unify these as follows:
| else if (i >= 3 && i <= 7) /* {zh,cmn,hak,nan,lzh}_TW */
| {
| [...]
| }
Regards,
TAMUKI Shoichi