This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] nptl/tst-rwlock14: Test pthread_rwlock_timedwrlock correctly
On 20/03/2019 14:27, Mike Crowe wrote:
> On Tuesday 19 March 2019 at 18:49:09 -0300, Adhemerval Zanella wrote:
>> On 17/03/2019 09:39, Mike Crowe wrote:
>>> The tests for out-of-bounds timespecs first test pthread_rwlock_timedrdlock
>>> and then pthread_rwlock_timedwrlock. It appears that the second and third
>>> tests suffered from copy-and-paste errors and each test
>>> pthread_rwlock_timedrdlock twice in a row. Let's correct that so that
>>> pthread_rwlock_timedwrlock is tested too.
>>>
>>> * nptl/tst-rwlock14.c (do_test): Replace duplicate calls to
>>> pthread_rwlock_timedrdlock with calls to
>>> pthread_rwlock_timedwrlock to ensure that the latter is tested
>>> too. Use new function name in diagnostic messages too.
>>
>> LGTM, but since you are there could you adapt it to libsupport?
>
> Yes. I plan to convert all the tests that I'm touching to use libsupport
> and then rebase my clockwait patches on top of that.
>
> However, in this case only I think I'd prefer to land this fix on its own
> first.
>
> Thanks for the review.
Fair enough.