This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 6/6] powerpc: Use generic wcscpy optimization
> [PATCH v2 6/6] powerpc: Use generic wcscpy optimization
In the commit headline, replace wcscpy with wcsrchr.
On Wed, Mar 13 2019, Adhemerval Zanella wrote:
> This patch removes the power6 wcsrchr optimization and use generic
> implementation instead. Currently both power6 and power7 ifunc variant
> resulting binary are essentially the same and the generic implementation
> with unrolling loop set to 8 also results in similar performance.
The patch looks good to me with the commit headline (see above) and
ChangeLog (see below) fixed.
Reviewed-by: Gabriel F. T. Gomes <gabriel@inconstante.eti.br>
> * sysdeps/powerpc/Makefile [$(subdir) == wcsmbs] (CFLAGS-wcschr.c):
> New rule.
s/wcschr/wcsrchr/
> * sysdeps/powerpc/power6/wcsrchr.c: Remove file.
> * sysdeps/powerpc/powerpc32/power4/multiarch/wcsrchr-power6.c:
> Likewise.
> * sysdeps/powerpc/powerpc32/power4/multiarch/wcsrchr-power7.c:
> Likewise.
> * sysdeps/powerpc/powerpc32/power4/multiarch/wcsrchr-ppc32.c:
> Likewise.
> * sysdeps/powerpc/powerpc32/power4/multiarch/wcsrchr.c: Likewise.
> * sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c: Likewise.
This file has not been removed, maybe you could just move it...
> * sysdeps/powerpc/powerpc64/multiarch/wcsrchr-power6.c: Likewise.
> * sysdeps/powerpc/powerpc64/multiarch/wcsrchr-power7.c: Likewise.
> * sysdeps/powerpc/powerpc64/multiarch/wcsrchr-ppc64.c: Likewise.
> * sysdeps/powerpc/powerpc64/multiarch/wcsrchr.c: Likewise.
> * sysdeps/powerpc/powerpc64/power6/wcsrchr.c: Likewise.
> * sysdeps/powerpc/powerpc32/power4/multiarch/Makefile
> [$(subdir) == wcsmbs] (sysdeps_routines): Remove wcsrchr-power6 and
> wcsrchr-power7.
> (CFLAGS-wcsrchr-power7.c, CFLAGS-wcsrchr-power6.c): Remove rule.
> * sysdeps/powerpc/powerpc64/multiarch/Makefile: Likewise.
> * sysdeps/powerpc/powerpc32/power4/multiarch/ifunc-impl-list.c:
> Remove wcsrchr optimizations.
... Here.