This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH 5/5] python scripts: don't use "==" to compare to None
- From: Konstantin Kharlamov <Hi-Angel at yandex dot ru>
- To: libc-alpha at sourceware dot org
- Date: Sun, 24 Mar 2019 15:21:21 +0300
- Subject: [PATCH 5/5] python scripts: don't use "==" to compare to None
- References: <20190324122121.6430-1-Hi-Angel@yandex.ru>
Fixes 4 LGTM warnings "Testing for None should use the 'is' operator."
Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru>
---
math/gen-tgmath-tests.py | 6 +++---
nptl/nptl-printers.py | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/math/gen-tgmath-tests.py b/math/gen-tgmath-tests.py
index 724a437b69..b6b068c6b3 100755
--- a/math/gen-tgmath-tests.py
+++ b/math/gen-tgmath-tests.py
@@ -385,7 +385,7 @@ class Tests(object):
elif ret == 'g' or 'g' in args:
# Real and complex.
have_complex = True
- if complex_func == None:
+ if complex_func is None:
complex_func = 'c%s' % func
types = [ret] + args
for t in types:
@@ -396,7 +396,7 @@ class Tests(object):
continue
if t.complex and not have_complex:
continue
- if func == None and not t.complex:
+ if func is None and not t.complex:
continue
if ret == 's' and t.name.startswith('_Float'):
continue
@@ -449,7 +449,7 @@ class Tests(object):
can_comb = Type.can_combine_types(this_args)
all_conds = [t.condition for t in this_args]
all_conds.append(can_comb)
- any_complex = func == None
+ any_complex = func is None
for t in this_args:
if t.complex:
any_complex = True
diff --git a/nptl/nptl-printers.py b/nptl/nptl-printers.py
index 493dfa0889..71962b1103 100644
--- a/nptl/nptl-printers.py
+++ b/nptl/nptl-printers.py
@@ -587,7 +587,7 @@ def register(objfile):
printer.add_printer('pthread_rwlockattr_t', r'^pthread_rwlockattr_t$',
RWLockAttributesPrinter)
- if objfile == None:
+ if objfile is None:
objfile = gdb
gdb.printing.register_pretty_printer(objfile, printer)
--
2.21.0