Re: [PATCH 4/5] resolv: don't pass struct ns_mst by value

[Florian Weimer <fw at deneb dot enyo dot de>]

* Konstantin Kharlamov:

> Fixes LGTM warning: "This parameter of type ns_msg is 80 bytes -
> consider passing a const pointer/reference instead."
>
> Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru>
> ---
>  resolv/arpa/nameser.h | 2 +-
>  resolv/ns_parse.c     | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/resolv/arpa/nameser.h b/resolv/arpa/nameser.h
> index a99d5ec508..7d2f717848 100644
> --- a/resolv/arpa/nameser.h
> +++ b/resolv/arpa/nameser.h
> @@ -390,7 +390,7 @@ typedef enum __ns_cert_types {
>  } while (0)
>  
>  __BEGIN_DECLS
> -int		ns_msg_getflag (ns_msg, int) __THROW;
> +int		ns_msg_getflag (const ns_msg*, int) __THROW;

Surely that's not right because this is an installed header, so it
would break ABI.