This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/5] support: don't pass to set_search_path a big struct by value

From: Florian Weimer <fw at deneb dot enyo dot de>
To: Konstantin Kharlamov <hi-angel at yandex dot ru>
Cc: libc-alpha at sourceware dot org
Date: Wed, 27 Mar 2019 09:56:25 +0100
Subject: Re: [PATCH 1/5] support: don't pass to set_search_path a big struct by value
References: <20190324122121.6430-1-Hi-Angel@yandex.ru> <20190324122121.6430-2-Hi-Angel@yandex.ru> <1553676609.10530.1@yandex.ru>

* Konstantin Kharlamov:

> It matters in terms of the code as read by human: α) one would no 
> longer wonder why "by-value" is used instead of a "by-pointer",

With by-pointer, the reader has to wonder if the called function
retains a pointer after the call, so it is a wash in this regard.

Follow-Ups:
- Re: [PATCH 1/5] support: don't pass to set_search_path a big struct by value
  - From: Konstantin Kharlamov

References:
- [PATCH 0/5] Minor LGTM fixes
  - From: Konstantin Kharlamov
- [PATCH 1/5] support: don't pass to set_search_path a big struct by value
  - From: Konstantin Kharlamov
- Re: [PATCH 1/5] support: don't pass to set_search_path a big struct by value
  - From: Konstantin Kharlamov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]