This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix strptime era handling, add more era tests [BZ #24394]


On 3/28/19 12:43 PM, Joseph Myers wrote:
On Thu, 28 Mar 2019, Carlos O'Donell wrote:

(a) Explicit code points.

I would like to see something like this:

"<U5E73><U6210>3<U5E74>"

Which is then converted by the test framework into the output encoding.

Using \u escape sequences in the string would be better (provided you want
a UTF-8 string, -fexec-charset=utf-8 is the GCC default and is implemented
entirely within GCC without depending on what iconv support might be
available for the host GCC runs on).  Note that we already have various
tests using \u.

Good idea, I forgot all about \u.
(For tests using non-UTF-8 encodings, hex escape sequences for the
individual characters may be safer, to avoid dependence on iconv support
linked into GCC.)
Good point.

So perhaps a mix of \u for UTF-8 and \x for non-UTF-8 to avoid a
dependency on iconv/glibc again.

I'd still like to see a comment indicating how the data was
generated.

--
Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]