This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Fix strptime era handling, add more era tests [BZ #24394]
- From: DJ Delorie <dj at redhat dot com>
- To: Rafal Luzynski <digitalfreak at lingonborough dot com>
- Cc: codonell at redhat dot com, libc-alpha at sourceware dot org, tamuki at linet dot gr dot jp
- Date: Thu, 28 Mar 2019 15:15:14 -0400
- Subject: Re: Fix strptime era handling, add more era tests [BZ #24394]
Rafal Luzynski <digitalfreak@lingonborough.com> writes:
> I think we have already written UTF-8 codes explicitly in some other
> tests so I think it would be OK here as well. However, I'd like to
> see the actual glyphs written in the comment to explain what these
> binary codes should mean. I think it is nice for a potential reviewer
> who is able to read this particular script.
I don't mind having UTF-8 in comments, but... it always works in gcc,
right?
And that leads to the question "what about tests for non-utf8 locales" ?
Do we put the UTF-8 glyphs in the comments, or just omit them?