Re: [v4] Fix strptime era handling, add more era tests [BZ #24394]

[Carlos O'Donell <codonell at redhat dot com>]

On 3/30/19 8:52 AM, TAMUKI Shoichi wrote:
> Hello Carlos-san,
>
> From: Carlos O'Donell <codonell@redhat.com>
> Subject: Re: [v4] Fix strptime era handling, add more era tests [BZ #24394]
> Date: Fri, 29 Mar 2019 16:40:22 -0400
>
> > .. and tst-strftime2.c is hideous, a terrible test with no comments
> > whose logic cannot be followed.
>
> Thank you for the comment. Certainly, it is fatal that the logic
> cannot be followed because there are not enough comments.  I am going
> to use this test suite for new features related to %EY in the future,
> so I will make the test suite easier to maintain.

That would be really excellent. Thank you for this effort.

Comments documenting intent.

Comments documenting what the mkreftable() code does.

When you use code to auto-generate the data you really must be clear
about intent and design, otherwise it's difficult to maintain.

--
Cheers,
Carlos.