Re: [PATCH v2 1/2] Y2038: make __mktime_internal compatible with __time64_t

[Lukasz Majewski <lukma at denx dot de>]

Hi Joseph,

> On Fri, 29 Mar 2019, Lukasz Majewski wrote:
> 
> > I've proposed to install struct __timespec64/__timeval64
> > in ./include/bits/types directory of glibc (and as fair as I
> > understand those would be private).  
> 
> Almost all include/bits headers are single-line wrappers round the 
> installed header.  Given that <bits/*.h> is a namespace specifically
> for *installed* header fragments included from other installed
> headers, you need a very good reason to put actual type definitions
> in include/bits/.
> 
> > But also, those can be placed in ./include/time.h  
> 
> Yes, that's a more appropriate place for internal type definitions.
> 

Ok, I see. Thanks for clarification.


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

Attachment: pgp_lmRb1QMwi.pgp
Description: OpenPGP digital signature