This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Linux: Implement per-thread file system attributes
* Andreas Schwab:
> On Apr 15 2019, Florian Weimer <fweimer@redhat.com> wrote:
>
>> diff --git a/sysdeps/unix/sysv/linux/createthread.c b/sysdeps/unix/sysv/linux/createthread.c
>> index 579bd94743..3516077ded 100644
>> --- a/sysdeps/unix/sysv/linux/createthread.c
>> +++ b/sysdeps/unix/sysv/linux/createthread.c
>> @@ -66,7 +66,9 @@ create_thread (struct pthread *pd, const struct pthread_attr *attr,
>>
>> CLONE_VM, CLONE_FS, CLONE_FILES
>> These flags select semantics with shared address space and
>> - file descriptors according to what POSIX requires.
>> + file descriptors according to what POSIX requires. CLONE_FS
>> + is optional; it can be using the function
>> + pthread_attr_setperthreadfs_np.
>
> That sentence lacks a verb.
Thanks, what about this?
CLONE_VM, CLONE_FS, CLONE_FILES
These flags select semantics with shared address space and
file descriptors according to what POSIX requires. CLONE_FS
- is optional; it can be using the function
+ is optional; it can be controlled using the function
pthread_attr_setperthreadfs_np.
Do you have an opinion whether we should go with the sticky or
non-sticky approach?
Thanks,
Florian