This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2] stdlib/tst-secure-getenv: handle >64 groups

From: Florian Weimer <fweimer at redhat dot com>
To: Mike Gerow <gerow at google dot com>
Cc: libc-alpha at sourceware dot org
Date: Tue, 16 Apr 2019 14:43:53 +0200
Subject: Re: [PATCH v2] stdlib/tst-secure-getenv: handle >64 groups
References: <878swo4vxv.fsf@oldenburg2.str.redhat.com> <20190405195135.GA20514@google.com>

* Mike Gerow:

> This test would fail unnecessarily if the user running it had more than
> 64 groups since getgroups returns EINVAL if the size provided is less
> than the number of supplementary group IDs. Instead dynamically
> determine the number of supplementary groups the user has.

Looks good.  Do you have commit access?  If not, I can add a ChangeLog
entry and push this on your behalf.

Thanks,
Florian

Follow-Ups:
- Re: [PATCH v2] stdlib/tst-secure-getenv: handle >64 groups
  - From: Mike Gerow

References:
- Re: [PATCH 1/1] stdlib/tst-secure-getenv: handle >64 groups
  - From: Florian Weimer
- [PATCH v2] stdlib/tst-secure-getenv: handle >64 groups
  - From: Mike Gerow

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]