This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2] support: Add support_capture_subprogram
On 17/04/2019 00:49, Carlos O'Donell wrote:
> On 4/16/19 5:27 PM, Adhemerval Zanella wrote:> Its API is similar to support_capture_subprogram, but rather creates a> new process based on the input path and arguments. Under the hoods it> uses posix_spawn to create the new process.
> Do you mean similar to support_capture_subprocess?
Oops, yes I meant support_capture_sub*process*.
>
> LGTM if:
> - you adjust commit message.
> - drop unrelated change.
Fixed both.
>
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
>> diff --git a/support/Makefile b/support/Makefile
>> index f173565202..4daf3f46fb 100644
>> --- a/support/Makefile
>> +++ b/support/Makefile
>> @@ -63,6 +63,7 @@ libsupport-routines = \
>> support_record_failure \
>> support_run_diff \
>> support_shared_allocate \
>> + support_subprocess \
>
> OK.
>
>> support_test_compare_blob \
>> support_test_compare_failure \
>> support_test_compare_string \
>> @@ -151,6 +152,9 @@ libsupport-routines = \
>> xsignal \
>> xsigstack \
>> xsocket \
>> + xposix_spawn \
>> + xposix_spawn_file_actions_addclose \
>> + xposix_spawn_file_actions_adddup2 \
>
> OK.
>
>> xstrdup \
>> xstrndup \
>> xsymlink \
>> @@ -210,7 +214,7 @@ tests = \
>> tst-test_compare_blob \
>> tst-test_compare_string \
>> tst-xreadlink \
>> - tst-xsigstack \
>> + tst-xsigstack
>
> Drop unrelated changes.
Ack.