This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 01/28] powerpc: Use generic fabs{f} implementations
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: Tulio Magno Quites Machado Filho <tuliom at ascii dot art dot br>, "Gabriel F. T. Gomes" <gabriel at inconstante dot eti dot br>
- Cc: Joseph Myers <joseph at codesourcery dot com>, libc-alpha at sourceware dot org
- Date: Wed, 17 Apr 2019 14:08:47 -0300
- Subject: Re: [PATCH 01/28] powerpc: Use generic fabs{f} implementations
- References: <20190329133529.22523-1-adhemerval.zanella@linaro.org> <20190329133529.22523-2-adhemerval.zanella@linaro.org> <alpine.DEB.2.21.1904012003110.27216@digraph.polyomino.org.uk> <b2c8dfa0-2a1c-1f6c-ba29-4cbe7d639faf@linaro.org> <20190415202356.7cltpw3akrcxjv6e@tereshkova> <87d0ln2bv4.fsf@linux.ibm.com>
On 15/04/2019 18:32, Tulio Magno Quites Machado Filho wrote:
> "Gabriel F. T. Gomes" <gabriel@inconstante.eti.br> writes:
>
>> The code generated by these functions is as follows (on powerpc64le):
>>
>> Before the patch:
>> 000000000004dac0 <fabs>:
>> 4dac0: 0e 00 4c 3c addis r2,r12,14
>> 4dac4: 40 9b 42 38 addi r2,r2,-25792
>> 4dac8: 10 0a 20 fc fabs f1,f1
>> 4dacc: 20 00 80 4e blr
>>
>> After the patch:
>> 000000000004dac0 <fabs>:
>> 4dac0: 10 0a 20 fc fabs f1,f1
>> 4dac4: 20 00 80 4e blr
>
> This is showing that __fabs could have been using ENTRY_TOCLESS instead of
> ENTRY. ;-)
>
And another point try use C implementation where possible (since it
abstracts that kind of possible ABI issues) ;)