This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] locale: Add LOCPATH diagnostics to the locale program
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Tue, 23 Apr 2019 21:57:24 +0000
- Subject: Re: [PATCH] locale: Add LOCPATH diagnostics to the locale program
- References: <87sgu8eozk.fsf@oldenburg2.str.redhat.com>
On Tue, 23 Apr 2019, Florian Weimer wrote:
> diff --git a/locale/Makefile b/locale/Makefile
> index 764e751c36..6822b795dd 100644
> --- a/locale/Makefile
> +++ b/locale/Makefile
> @@ -28,6 +28,7 @@ routines = setlocale findlocale loadlocale loadarchive \
> localeconv nl_langinfo nl_langinfo_l mb_cur_max \
> newlocale duplocale freelocale uselocale
> tests = tst-C-locale tst-locname tst-duplocale
> +tests-special = $(objpfx)tst-locale-locpath.out
> categories = ctype messages monetary numeric time paper name \
> address telephone measurement identification collate
> aux = $(categories:%=lc-%) $(categories:%=C-%) SYS_libc C_name \
> @@ -107,3 +108,7 @@ cpp-srcs-left := $(localedef-modules) $(localedef-aux) $(locale-modules) \
> $(lib-modules)
> lib := locale-programs
> include $(patsubst %,$(..)libof-iterator.mk,$(cpp-srcs-left))
> +
> +$(objpfx)tst-locale-locpath.out : tst-locale-locpath.sh $(objpfx)locale
> + $(SHELL) $< '$(common-objpfx)' '$(test-wrapper)' '$(test-wrapper-env)' > $@; \
> + $(evaluate-test)
This is missing run-built-tests conditionals so wrongly tries to run the
test unconditionally for cross-compilation.
https://sourceware.org/ml/libc-testresults/2019-q2/msg00081.html
--
Joseph S. Myers
joseph@codesourcery.com