Re: [patch-ish, WIP] Enhance comments in nsswitch.h

[Carlos O'Donell <codonell at redhat dot com>]

On 5/8/19 5:39 PM, DJ Delorie wrote:
> "Carlos O'Donell" <codonell@redhat.com> writes:
> > > +  /* And the link to the next entry.  In a typical nsswitch.conf, this
> > > +     is the passwd->group->hosts link.  */
> >
> > What does this mean? That this is the next entry in the file after
> > translating it into a lit of entries (excluding comments)?
>
> It's a link to, essentially, the next non-comment line in nsswitch.conf.
> There are a lot of things labelled "next" in this header, keeping track
> of next *what* is important.

I agree. Please mention that in the comment.

> We also don't have a lot of consistency and well-known terms for things
> like "passwd or hosts" vs "dns or files" etc.
>
> > > +/* The rest of this header is not-data.  */
> >
> > Remove this comment.
>
> This is just a hint to me to stop reading the file ;-)

Ha! :-)

Please post a v2. I'd like to see this committed.

--
Cheers,
Carlos.