This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix tcache count maximum
- From: DJ Delorie <dj at redhat dot com>
- To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
- Cc: codonell at redhat dot com, libc-alpha at sourceware dot org, nd at arm dot com
- Date: Thu, 09 May 2019 11:58:07 -0400
- Subject: Re: [PATCH] Fix tcache count maximum
Wilco Dijkstra <Wilco.Dijkstra@arm.com> writes:
> So it's misleading to quote the maximum amount of memory held in tcache as
> a useful figure when no application would ever see that in reality.
It's useful if the users typically ask "how much extra memory could the
tcache use?" The difficult part is coming up with a small amount of
documentation that gives the most users a reasonable answer to the most
likely questions, without putting in so much documentation that it
becomes confusing and thus unread.
Putting in an upper limit gives the user an answer, and since it's a
small number, it need not be precise.
> but the key point is that we can improve the tcache significantly.
Please do! I knew going into this that the tcache could have lots of
enhancements, but I wanted to keep it simple for review purposes.
The only tricky part is agreeing on which benchmarks are valid ;-)