This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: glibc git commit hooks update.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Carlos O'Donell <codonell at redhat dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>, Mark Wielaard <mjw at redhat dot com>, Nick Clifton <nickc at redhat dot com>, Jeff Law <law at redhat dot com>, "Frank Ch. Eigler" <fche at redhat dot com>, Pedro Alves <palves at redhat dot com>, Florian Weimer <fweimer at redhat dot com>
- Date: Thu, 16 May 2019 19:35:38 +0000
- Subject: Re: glibc git commit hooks update.
- References: <56d46408-8314-aa01-91da-f8e32f2f56d1@redhat.com> <alpine.DEB.2.21.1904172216090.14148@digraph.polyomino.org.uk> <ed822689-7171-b1de-ed46-bec81c9f266e@redhat.com>
On Wed, 17 Apr 2019, Carlos O'Donell wrote:
> > One problem with the old hooks was that they did not generate a
> > Content-Type header, which was unhelpful when the mails also weren't pure
> > ASCII. I see the new ones are generating 'Content-Type: text/plain;
> > charset="us-ascii"'. Will they also be smart about specifying an
> > appropriate character set (so UTF-8 if the commit message / author name /
> > diff contents are valid UTF-8 but not ASCII, for example)?
>
> All of this is handled by python's email package and some handling
> on the hooks part. If everything is ASCII then we don't do any special
> encoding and just send ASCII. Otherwise we choose UTF-8 first and if
> that fails a decode test then we fallback to ISO-8859-1.
This does not seem to be working as intended. See e.g.
https://sourceware.org/ml/glibc-cvs/2019-q2/msg00147.html (UTF-8 bytes
marked as us-ascii, so ’ appears as â??, for example).
--
Joseph S. Myers
joseph@codesourcery.com