This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove support for PowerPC e500 / SPE ISA extension.
On Thu, May 16, 2019 at 5:12 PM Segher Boessenkool
<segher@kernel.crashing.org> wrote:
> On Thu, May 16, 2019 at 08:24:02PM +0000, Joseph Myers wrote:
> > On Thu, 16 May 2019, Segher Boessenkool wrote:
> > > It didn't. It removed support for the SPE vector extensions only.
> >
> > And -mfloat-gprs=*, which goes along with them
>
> I meant ISA extension. But yes, all the more user-facing stuff was
> removed as well of course. I didn't phrase that very well, sorry.
It was my intention to remove only the code within glibc that was
required for powerpc-*-*gnuspe* configurations. I'm not super
familiar with the ins and outs of PowerPC, though, so I could easily
have gotten something wrong. I'm particularly worried about
sysdeps/powerpc/preconfigure, which was using predefined macros, not
$host_os, to decide whether to enable the "e500" sysdeps directories:
> - $CC $CFLAGS $CPPFLAGS -E -dM -xc /dev/null > conftest.i
> - if grep -q __NO_FPRS__ conftest.i && ! grep -q _SOFT_FLOAT conftest.i; then
> - base_machine=powerpc machine=powerpc/powerpc32/e500
> - else
> - base_machine=powerpc machine=powerpc/powerpc32
> - fi
If __NO_FPRS__ might ever be defined, without _SOFT_FLOAT also being
defined, on a plain powerpc-*-*gnu configuration, then this change is
wrong.
zw