This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/5] sysvipc: Consolidate semtimedop s390


* Adhemerval Zanella:

> On 16/05/2019 12:41, Florian Weimer wrote:
>> * Adhemerval Zanella:
>> 
>>> diff --git a/sysdeps/unix/sysv/linux/ipc_priv.h b/sysdeps/unix/sysv/linux/ipc_priv.h
>>> index 65adbb093e..49018c1b28 100644
>>> --- a/sysdeps/unix/sysv/linux/ipc_priv.h
>>> +++ b/sysdeps/unix/sysv/linux/ipc_priv.h
>>> @@ -34,4 +34,7 @@ struct __old_ipc_perm
>>>  #define MSGRCV_ARGS(__msgp, __msgtyp) \
>>>    ((long int []){ (long int) __msgp, __msgtyp })
>>>  
>>> +#define SEMTIMEDOP_IPC_ARGS(__nsops, __sops, __timeout) \
>>> +  (__nsops), 0, (__sops), (__timeout)
>> 
>> Maybe add a reference to the s390 version?
>
> What about: 
>
> /* This macro is required to handle the s390 variants, which passes the
>    arguments in a different order than default.  */

Isn't this for s390 (31-bit) only?

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]