Re: [PATCH] test-in-container: Do not set GCONV_PATH, LOCPATH

[Florian Weimer <fweimer at redhat dot com>]

* DJ Delorie:

> There's code in test-container.c to not propogate environment variables
> to the in-container test:
>
>       while (is_env_setting (argv[1]))
> 	{
> 	  /* If there are variables we do NOT want to propogate, this
> 	     is where the test for them goes.  */
> 	    {
>
> That way we can treate test-container itself like any other testcase,
> and have it worry about "cleaning" the environment for the contained
> tests.

Still there is a separate Rules recipe.

> The source/build directories are loop-mounted inside the container, so
> such environment variables *should* work if set, and there were some
> test when I was testing everything in containers that still needed those
> vars set.

They probably use locales that are not installed, or not installed under
the names configured for the test, so that's not unexpected.

The problem is that setting GCONV_PATH alters iconv behavior (it
disables the cache).  Similar for LOCPATH.  Setting those variables
really limits the scope of the test-in-container framework.

Thanks,
Florian