This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 2/2] Update sysvipc kernel-features.h files for Linux 5.1

From: Joseph Myers <joseph at codesourcery dot com>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
Cc: <libc-alpha at sourceware dot org>
Date: Mon, 20 May 2019 19:10:16 +0000
Subject: Re: [PATCH v2 2/2] Update sysvipc kernel-features.h files for Linux 5.1
References: <20190520175341.17310-1-adhemerval.zanella@linaro.org> <20190520175341.17310-2-adhemerval.zanella@linaro.org>

As a general issue in this patch, you're missing spaces before '(' in 
calls to 'defined'.  'defined' should be treated like a function for this 
purpose, and have such spaces (the parentheses are optional, you can just 
do "defined MACRO").

-- 
Joseph S. Myers
joseph@codesourcery.com

Follow-Ups:
- Re: [PATCH v2 2/2] Update sysvipc kernel-features.h files for Linux 5.1
  - From: Adhemerval Zanella

References:
- [PATCH v2 1/2] ipc: Refactor sysvipc internal definitions
  - From: Adhemerval Zanella
- [PATCH v2 2/2] Update sysvipc kernel-features.h files for Linux 5.1
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]