This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/8] Define register_t using bits/typesizes.h macros.
* Zack Weinberg:
> On Wed, May 22, 2019 at 10:42 AM Florian Weimer <fweimer@redhat.com> wrote:
>> * Zack Weinberg:
>> > * sysdeps/unix/sysv/linux/mips/bits/typesizes.h:
>> > New file (copied from bits/typesizes.h).
>> > Define __REGISTER_T_TYPE as __SWORD_TYPE for o32 and n64 ABIs.
>> > Define __REGISTER_T_TYPE as __SQUAD_TYPE for n32.
>>
>> Are you sure you used the correct template for this? I would have
>> expected mips to use sysdeps/unix/sysv/linux/generic/bits/typesizes.h
>> before.
>
> Yes, I am sure; I initially wrote this patch by copying
> linux/generic/bits/typesizes.h and the ABI checks barfed. Only
> aarch64, nios2, riscv, and csky mention linux/generic in their Implies
> files at present.
Ahh. So sysdeps/generic and sysdeps/unix/sysv/linux/generic serve
very different roles. I'll keep this in mind for the future.
The diff against bits/typesizes.h looks indeed reasonable.
I have reviewed the other changes as well and they look good to me.