This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2] PPC64: Add libmvec SIMD double-precision natural exponent function.
Shawn Landden <shawn@git.icu> writes:
>> > diff --git a/sysdeps/powerpc/powerpc64/fpu/multiarch/vec_d_exp_data.c
>> b/sysdeps/powerpc/powerpc64/fpu/multiarch/vec_d_exp_data.c
>> > new file mode 100644
>> > index 0000000000..650fdee75f
>> > --- /dev/null
>> > +++ b/sysdeps/powerpc/powerpc64/fpu/multiarch/vec_d_exp_data.c
>> > @@ -0,0 +1,200 @@
>> > +/*
>> > + * Shared data between exp, exp2 and pow.
>> > + *
>> > + * Copyright (c) 2018, Arm Limited.
>> > + * SPDX-License-Identifier: MIT
>> > + */
>>
>> Do you have the approval from the copyright holder to contribute this file?
>>
> This is already part of glibc, I just put the wrong header on it.
Awesome!
Could you mention in your commit message that your patch is based on another
implementation, please?
It's very important to mention which implementation is that in order to
recognize the original authors and to help computational archaeologists.
Likewise for patch #1, if it's also based on another code.
--
Tulio Magno