This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] powerpc: Fix build failures with current GCC
- From: Tulio Magno Quites Machado Filho <tuliom at ascii dot art dot br>
- To: gabriel at inconstante dot eti dot br, libc-alpha at sourceware dot org
- Cc:
- Date: Wed, 29 May 2019 13:41:17 -0300
- Subject: Re: [PATCH] powerpc: Fix build failures with current GCC
- References: <20190528185718.28393-1-gabriel@inconstante.eti.br>
<gabriel@inconstante.eti.br> writes:
> * sysdeps/powerpc/Makefile (CFLAGS-tst-set_ppr.c): New variable.
This entry is missing this:
[$(subdir) == misc]
> diff --git a/sysdeps/powerpc/Makefile b/sysdeps/powerpc/Makefile
> index 05675bc8ae..517a7297ec 100644
> --- a/sysdeps/powerpc/Makefile
> +++ b/sysdeps/powerpc/Makefile
> @@ -45,6 +45,7 @@ ifeq ($(subdir),misc)
> sysdep_headers += sys/platform/ppc.h
> tests += test-gettimebase
> tests += tst-set_ppr
> +CFLAGS-tst-set_ppr.c += -Wa,-many
We need a comment explaining why this is needed, stating the test is expected
to run and exit with EXIT_UNSUPPORTED on processors that do not implement
the Power ISA 2.06 or greater.
But the test makes usage of instructions from Power ISA 2.06 and 2.07.
LGTM with these changes.
Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
--
Tulio Magno