This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] [powerpc] fpu_control.h: protect use of __builtin_cpu_supports()

From: Florian Weimer <fweimer at redhat dot com>
To: Andreas Schwab <schwab at suse dot de>
Cc: "Paul A. Clarke" <pc at us dot ibm dot com>, libc-alpha at sourceware dot org, tuliom at ascii dot art dot br, law at redhat dot com, carlos at redhat dot com
Date: Tue, 09 Jul 2019 12:07:29 +0200
Subject: Re: [PATCH] [powerpc] fpu_control.h: protect use of __builtin_cpu_supports()
References: <1562630076-11320-1-git-send-email-pc@us.ibm.com> <87wogrlogu.fsf@oldenburg2.str.redhat.com> <mvmsgrfczab.fsf@suse.de>

* Andreas Schwab:

> On Jul 09 2019, Florian Weimer <fweimer@redhat.com> wrote:
>
>> * Paul A. Clarke:
>>
>>> From: "Paul A. Clarke" <pc@us.ibm.com>
>>>
>>> Using __builtin_cpu_supports() requires support in GCC and Glibc.
>>> My recent patch to fpu_control.h added an unprotected use of
>>> __builtin_cpu_supports(), and this is a user-visible file.
>>
>> Are you sure?  I don't think it's an installed header, and that's what
>> “user-visibile file” implies to me.
>
> It's in math/Makefile:headers.

fpu_control.h?  Yes.  But the changed file is
sysdeps/powerpc/fpu/fenv_libc.h, which I don't think is installed.

Thanks,
Florian

Follow-Ups:
- Re: [PATCH] [powerpc] fpu_control.h: protect use of __builtin_cpu_supports()
  - From: Paul Clarke

References:
- [PATCH] [powerpc] fpu_control.h: protect use of __builtin_cpu_supports()
  - From: Paul A. Clarke
- Re: [PATCH] [powerpc] fpu_control.h: protect use of __builtin_cpu_supports()
  - From: Florian Weimer
- Re: [PATCH] [powerpc] fpu_control.h: protect use of __builtin_cpu_supports()
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]