This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] [powerpc] fenv_libc.h: protect use of __builtin_cpu_supports()
- From: Florian Weimer <fweimer at redhat dot com>
- To: "Paul A. Clarke" <pc at us dot ibm dot com>
- Cc: libc-alpha at sourceware dot org, tuliom at ascii dot art dot br, schwab at suse dot de, law at redhat dot com, carlos at redhat dot com
- Date: Tue, 09 Jul 2019 18:21:59 +0200
- Subject: Re: [PATCH v2] [powerpc] fenv_libc.h: protect use of __builtin_cpu_supports()
- References: <1562683300-7622-1-git-send-email-pc@us.ibm.com>
* Paul A. Clarke:
> #ifdef _ARCH_PWR9
> # define fegetenv_status() fegetenv_status_ISA300()
> -#else
> +#elif defined __BUILTIN_CPU_SUPPORTS__
> # define fegetenv_status() \
> (__glibc_likely (__builtin_cpu_supports ("arch_3_00")) \
> ? fegetenv_status_ISA300() \
> : fegetenv_register() \
> )
> +#else
> +# define fegetenv_status() fegetenv_register()
Missing space before second () on the last line (but it's consistent
with the others 8-/).
Otherwise, this looks fine to me. Maybe drop the () from the commit
message, per GNU style guidelines.
Thanks,
Florian