Re: [PATCH] test-in-container: Install locales into the test container

[Florian Weimer <fweimer at redhat dot com>]

* DJ Delorie:

> Florian Weimer <fweimer@redhat.com> writes:
>> The testing time impact of this change is significant: It increases
>> total test time from ~13 to ~15 minutes for me.  However, I do not
>> see any other way to run locale-dependent tests in a container.
>
> This is also the only way to auto-test "make install-locales" too :-)
>
>>  	$(MAKE) install DESTDIR=$(objpfx)testroot.pristine
>> +	$(MAKE) localedata/install-locales DESTDIR=$(objpfx)testroot.pristine
>>  	touch $(objpfx)testroot.pristine/install.stamp
>
> This matches what's documented in INSTALL so LGTM.
>
> Reviewed-by: DJ Delorie <dj@redhat.com>

The problem is that the delay also applies to partial runs of the test
suite:

$ time make -j8 subdirs=resolv check

goes from:

real    0m8.792s
user    0m15.486s
sys     0m6.017s

to:

real    2m5.588s
user    13m20.667s
sys     0m44.631s

Compare this to the time of a clean glibc build on this machine:

real    1m42.489s
user    8m20.556s
sys     2m6.281s

This is a bit embarrassing because the pristine container constructed in
this way is not even correct (bug 24794).

I think applying this patch as-is would make glibc development
substantially more difficult for me.

Thanks,
Florian