This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC v2 08/20] sysdeps/wait: Use waitid if avaliable
- From: Alistair Francis <alistair23 at gmail dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: Florian Weimer <fweimer at redhat dot com>, Arnd Bergmann <arnd at arndb dot de>, Zack Weinberg <zackw at panix dot com>, Alistair Francis <alistair dot francis at wdc dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 10 Jul 2019 10:47:51 -0700
- Subject: Re: [RFC v2 08/20] sysdeps/wait: Use waitid if avaliable
- References: <cover.1561421042.git.alistair.francis@wdc.com> <2df9d3878359585ac1cc46243fb6664f7a50b3b3.1561421042.git.alistair.francis@wdc.com> <CAKCAbMhyUiEZcfg-BNL_sqUAFmtEWCEgoyUwMGOdB_jLbvKJ6Q@mail.gmail.com> <87ftnx6i0m.fsf@oldenburg2.str.redhat.com> <CAK8P3a39tr-qbG4X8SnM=3M6VfV+LzOvE6pVBqByN0YcPkf42w@mail.gmail.com> <877e9950hj.fsf@oldenburg2.str.redhat.com> <CAK8P3a0P1f=922peKELqanZqSY3MAdNiUK70UvZaxy75pS-2Qw@mail.gmail.com> <CAK8P3a2hj24voTemN54gBKay+cKU3vd_dr=KVacWjrO5foH3Bg@mail.gmail.com> <87a7e522wb.fsf@oldenburg2.str.redhat.com> <CAK8P3a3b32CNaXfR1w8cJuGS1H7qPTKLZc0BDxf-oW20i7aXvw@mail.gmail.com> <87r27hzrjd.fsf@oldenburg2.str.redhat.com> <CAK8P3a2HC_Ki0tf9B_A3Tm5w9zqrVLO8JG8u_ohc8aoSEY5okw@mail.gmail.com> <87ef3hzqjw.fsf@oldenburg2.str.redhat.com> <CAK8P3a2QW7WNuK0_zu44_fp3qWh7iL2V6Mae+zx+iLjUP7CitQ@mail.gmail.com> <8736jwjqkq.fsf@oldenburg2.str.redhat.com> <mvm36jwux93.fsf@suse.de> <878st8u3qp.fsf@oldenburg2.str.redhat.com> <mvmlfx8emc2.fsf@suse.de> <87bly4snx5.fsf@oldenburg2.str.redhat.com> <CAKmqyKN1VdEgu22qg4KTnn0+ZKa7u9RS+6RzZf0B_ujzNWu-Hw@mail.gmail.com> <mvm7e8qcpi3.fsf@suse.de>
On Wed, Jul 10, 2019 at 12:33 AM Andreas Schwab <schwab@suse.de> wrote:
>
> On Jul 09 2019, Alistair Francis <alistair23@gmail.com> wrote:
>
> > So that means that the #define solution (see below) is probably the
> > way to go then?
> >
> > #if __riscv_xlen == 32
> > # ifndef __NR_futex
> > # define __NR_futex __NR_futex_time64
> > # endif
> > #endif
>
> I don't think this is the way to go since all future 32-bit ABIs will
> have to do the same. The generic code should follow the default as
> defined by <asm-generic/unistd.h>.
I'm a little hesitant on making this change generic. This is what I'm
more thinking
1. Add RV32 support by RV32 specific defines (see above)
2. As other architectures move to this the RV32 fix can be either
moved to a generic include or if a different solution is decided upon
that can be used. The benefit here is that we don't end up pushing
everyone else to do what we do initially.
There will be some generic changes, we can't just #define everything
but this at least limits the generic code changes when we merge in the
RV32 port.
If everyone doesn't like this option though I'm happy to make the
changes generic.
Alistair
>
> Andreas.
>
> --
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."